Add creating reals from any numeral and getting f64 from reals #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waywardmonkeys
requested changes
May 29, 2024
z3/src/ast.rs
Outdated
| Self::from_str(ctx, &fraction_string) | ||
| } | ||
|
|
||
| /// The string may be of the form \[num\]*\[.\[num\]*\]\[E\[+|-\]\[num\]+\]. |
There was a problem hiding this comment.
Could you put ... around the \[num\]...+\] ?
lucascool12
force-pushed
the
feat-str-decimal-reals
branch
from
1d38944
to
7d2698a
Compare
|
I fixed the relevant parts of the CI, and then accidentally clicked close pull request, whoops. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to create Reals from any numeral using Z3_mk_numeral.
Also adds the method
as_f64toRealwhich uses Z3_get_numberal_double.This is useful if you want to represent a real as a f64. Currently you would have to calculate the numerator and denominator in order to create a z3 real from a f64. With this merge request all you would need to do is create a string from your f64 and pass this to
from_str.