Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change yes/no to true/false #101

Closed
remcohaszing opened this issue Sep 30, 2021 · 5 comments
Closed

Change yes/no to true/false #101

remcohaszing opened this issue Sep 30, 2021 · 5 comments
Labels
standard-breaking-change This change breaks backward compatibility vote-draft Change proposal to the Standard or to the governance procedures

Comments

@remcohaszing
Copy link

This specification defines a YAML file which should use yes/no is accepted in several places. However, the meaning of yes/no is ambiguous in YAML. In YAML 1.1 and older these values represent booleans, but in YAML 1.2 they don’t, meaning they represent strings.

I suggest to remove this ambiguity by changing them to unambigous booleans (true/false) in the specification.

@ruphy
Copy link
Member

ruphy commented Oct 5, 2021

thank you @remcohaszing, I think it's a good idea

@libremente
Copy link
Member

This issue was related #8

@libremente
Copy link
Member

See also italia/publiccode-editor#48

@remcohaszing
Copy link
Author

yaml-language-server 1.0 and VSCode Yaml 1.0 have just been released, where they switched from using YAML 1.1 to YAML 1.2. This means they will now mark the values yes/no as invalid, which comes from JSON schema validation based the publiccode JSON schema in the schema store.

@bfabio bfabio added vote-draft Change proposal to the Standard or to the governance procedures standard-breaking-change This change breaks backward compatibility labels Dec 5, 2021
@bfabio
Copy link
Contributor

bfabio commented Dec 11, 2021

I think explicitly base the format on YAML 1.2 is the number one issue we need to address. Moving to Discussions.

@publiccodeyml publiccodeyml locked and limited conversation to collaborators Dec 11, 2021
@bfabio bfabio converted this issue into discussion #115 Dec 11, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
standard-breaking-change This change breaks backward compatibility vote-draft Change proposal to the Standard or to the governance procedures
Projects
None yet
Development

No branches or pull requests

4 participants