Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "releaseDate" key an optional key #180

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

tomootes
Copy link
Contributor

As stated in the following thread. It would be logical to make the releaseDate key optional.

Main reasons that can be coined for this are:

  • Some repositories don't use release tags (SemVer). These repo's don't have a logical release date. In practice a lot of repositories will use Continuous Delivery and for these this will be the case.
  • It could be argued that it is undesirable if the publiccode.yml becomes a file that has to be updated very often. In the case of developer.overheid.nl we can also fetch the date of the last release via the Gitlab/Github API.

@bfabio
Copy link
Contributor

bfabio commented Dec 30, 2023

@tomootes, I agree with both points. Adding to the second: the need to update releaseDate every time results in either not updating it, or it becomes busywork that just annoys the maintainers and makes them roll their eyes at publiccode.yml.

Having it optional makes it available to people who wanna opt-in for that.

@bfabio
Copy link
Contributor

bfabio commented Dec 30, 2023

@yaml-9000 minor-change

@yaml-9000
Copy link

Thanks for your contribution 🙏

This is now marked as a minor-change proposal to the standard,
this means that old versions of publiccode.yml will still be valid with this change.

Example of minor changes are additions of new keys or making keys optional.

The Chair will eventually pick up this proposal and start the voting procedure using @yaml-9000 vote-start

cc @ruphy @publiccodeyml/steering-committee

📄 Voting procedure | 📄 Working Group Charter | 🤖 bot commands

@yaml-9000 yaml-9000 added standard-minor-change This change is backward compatible. It's a new feature. vote-draft Change proposal to the Standard or to the governance procedures labels Dec 30, 2023
@tomootes
Copy link
Contributor Author

@tomootes, I agree with both points. Adding to the second: the need to update releaseDate every time results in either not updating it, or it becomes busywork that just annoys the maintainers and makes them roll their eyes at publiccode.yml.

Having it optional makes it available to people who wanna opt-in for that.

I can't agree more on this one. In addition to this: if a project is using semver the last releasedate can easily be fetched from either Github or Gitlab. If we keep it mandatory this is going to be an extra chore for devs.

@bfabio
Copy link
Contributor

bfabio commented Mar 5, 2024

I updated the translations as well and rebased so the preview is successful.

@ruphy
Copy link
Member

ruphy commented May 29, 2024

@yaml-9000 vote-start

@yaml-9000
Copy link

Voting is now open on this proposal!

If you are a member of the Steering Committee you can now vote!

The polls will stay open for 14 days, until Wed, 12 Jun 2024 12:33:59 GMT.
At the end of that period the Chair (@publiccodeyml/chair) will mark the voting period as over using @yaml-9000 vote-end

Leave a 👍 (thumbs up) on this comment to accept the proposal or a 👎 (thumbs down) to reject it.

cc @publiccodeyml/steering-committee

📄 Voting procedure | 📄 Working Group Charter | 🤖 bot commands

@bfabio
Copy link
Contributor

bfabio commented Jun 13, 2024

@yaml-9000 vote-end

@yaml-9000
Copy link

Vote results

The results of the vote are:

Vote Members Votes count Percentage
👍 Approve @bzg @ruphy 2 100.0%
👎 Reject 0 -

Proposal approved 👍

This proposal is now ready to be merged and get released with a new version of the standard.

cc @publiccodeyml/chair @publiccodeyml/maintainers

Details

First round: unanimity required

The following users voted (includes non-members of the steering committee):

  • bfabio voted 👍

  • bzg voted 👍

  • ruphy voted 👍

📄 Voting procedure | 📄 Working Group Charter | 🤖 bot commands

@bfabio bfabio merged commit 1b26481 into publiccodeyml:main Jun 14, 2024
1 check passed
@tomootes
Copy link
Contributor Author

Awesome to see the change has been accepted and is now part of the standard 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standard-minor-change This change is backward compatible. It's a new feature. vote-approved vote-draft Change proposal to the Standard or to the governance procedures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants