Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Whistleblowing to the software categories list #97

Merged

Conversation

evilaliv3
Copy link
Contributor

Reference ticket: #96

@bfabio bfabio added vote-draft Change proposal to the Standard or to the governance procedures standard-minor-change This change is backward compatible. It's a new feature. labels Dec 5, 2021
@ruphy ruphy linked an issue Dec 13, 2021 that may be closed by this pull request
@evilaliv3 evilaliv3 force-pushed the add-whistleblowing-software-category branch from a4e0c1b to 86eabda Compare December 14, 2021 21:56
@bfabio
Copy link
Contributor

bfabio commented Mar 28, 2022

@yaml-9000 minor-change

@yaml-9000
Copy link

Thanks for your contribution 🙏

This is now marked as a minor-change proposal to the standard,
this means that old versions of publiccode.yml will still be valid with this change.

Example of minor changes are additions of new keys or making keys optional.

The Chair will eventually pick up this proposal and start the voting procedure using @yaml-9000 vote-start

cc @ruphy @publiccodeyml/steering-committee

📄 Voting procedure | 📄 Working Group Charter | 🤖 bot commands

@bfabio
Copy link
Contributor

bfabio commented Mar 28, 2022

Hello @evilaliv3, can you please rebase your PR on main?

@evilaliv3
Copy link
Contributor Author

Absolutely! Thank you for for suppporting this!

@evilaliv3 evilaliv3 force-pushed the add-whistleblowing-software-category branch from 86eabda to 88a85af Compare March 29, 2022 07:19
@evilaliv3
Copy link
Contributor Author

there you are @bfabio. than you again

cc @ruphy https://github.com/orgs/publiccodeyml/teams/steering-committee

@bfabio
Copy link
Contributor

bfabio commented Mar 29, 2022

Thank you @evilaliv3 :)

@evilaliv3
Copy link
Contributor Author

@bfabio @ruphy : looking forward to the merge we have anticipated adding the category to our files in order to be apple to re-test it early as available.

Thank you

@ruphy
Copy link
Member

ruphy commented Apr 13, 2022

@yaml-9000 vote-start

@yaml-9000
Copy link

Voting is now open on this proposal!

If you are a member of the Steering Committee you can now vote!

The polls will stay open for 14 days, until Wed, 27 Apr 2022 13:03:37 GMT.
At the end of that period the Chair (@ruphy) will mark the voting period as over using @yaml-9000 vote-end

Leave a 👍 (thumbs up) on this comment to accept the proposal or a 👎 (thumbs down) to reject it.

cc @publiccodeyml/steering-committee

📄 Voting procedure | 📄 Working Group Charter | 🤖 bot commands

@ruphy
Copy link
Member

ruphy commented Apr 29, 2022

@yaml-9000 vote-end

@yaml-9000
Copy link

Vote results

The results of the vote are:

Vote Members Votes count Percentage
👍 Approve @ruphy @bzg 2 100.0%
👎 Reject 0 -

Proposal approved 👍

This proposal is now ready to be merged and get released with a new version of the standard.

cc @ruphy @publiccodeyml/maintainers

Details

First round: unanimity required

The following users voted (includes non-members of the steering committee):

  • ruphy voted 👍

  • bzg voted 👍

📄 Voting procedure | 📄 Working Group Charter | 🤖 bot commands

@bfabio bfabio merged commit 1cbca39 into publiccodeyml:main May 2, 2022
@evilaliv3
Copy link
Contributor Author

Thank you @bfabio

Will this code run in production starting from tonight?

@evilaliv3 evilaliv3 deleted the add-whistleblowing-software-category branch May 2, 2022 08:27
@bfabio
Copy link
Contributor

bfabio commented May 2, 2022

@evilaliv3 this will take a while to get to production, we need to

  1. Release the new version of the Standard
  2. Bring all the changes to publiccode-parser-go and release a new version
  3. Make the publiccode crawler use the new version of publiccode-parser-go and deploy it

it'll take a few days

bfabio added a commit to bfabio/publiccode-parser-go that referenced this pull request May 10, 2022
@bfabio
Copy link
Contributor

bfabio commented May 12, 2022

@evilaliv3 FYI, the Italian crawler now supports the latest version of the Standard, so whistleblowing can be used.

@evilaliv3
Copy link
Contributor Author

evilaliv3 commented May 27, 2022

@bfabio @ruphy: I notice that the category has been correctly added to the system but the software page seems to not be able to use it.

https://developers.italia.it/it/software/globaleaks-globaleaks-f22648

Here for example you could see still missing the category whistleblowing.

Would you please check it on which component i should eventually open an issue?

Thank you!

@bfabio
Copy link
Contributor

bfabio commented May 27, 2022

@evilaliv3 that would be https://github.com/italia/developers.italia.it/ material, thanks 🙌

bfabio added a commit to bfabio/publiccode-parser-go that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
standard-minor-change This change is backward compatible. It's a new feature. vote-approved vote-draft Change proposal to the Standard or to the governance procedures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Whistleblowing" to the software categories list
4 participants