Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .onion #374

Closed
sleevi opened this issue Jan 5, 2017 · 15 comments · Fixed by #386
Closed

Add .onion #374

sleevi opened this issue Jan 5, 2017 · 15 comments · Fixed by #386
Assignees

Comments

@sleevi
Copy link
Contributor

sleevi commented Jan 5, 2017

RFC 7686 officially passed through the IETF, which lists .onion as a Special-Use Domain Name

Unlike those names specified in the IANA Special Use list ( https://www.iana.org/assignments/special-use-domain-names/special-use-domain-names.xhtml ), the set of .onion domains extend beyond local resolutions. That is, two clients, both configured to recognize .onion names, both resolve the name to the same party. This is different than, say, .localhost or .example, which will resolve to the local machine.

At present, .onion is captured by the existing implicit '*' in the algorithm, and so adding .onion would not have a meaningful change to the PSL, except in that it will recognize it as a domain 'blessed' by IANA/ICANN, for applications which use the PSL for that purpose.

As noted, "Note that the registration of .onion names does not prohibit IANA from inserting a record into the root zone database to reserve the name."

I'm hoping to use this bug to capture any reasons why it may be desirable to not add .onion

@sleevi sleevi assigned weppos and gerv Jan 5, 2017
@sleevi
Copy link
Contributor Author

sleevi commented Jan 5, 2017

@gerv @weppos @dnsguru Any thoughts?

@dnsguru
Copy link
Member

dnsguru commented Jan 7, 2017 via email

@gerv
Copy link
Contributor

gerv commented Jan 10, 2017

I think it makes sense to add it, although it's true that it doesn't fit neatly into the definition of either section.

@galeksandrp
Copy link

Please also

https://en.wikipedia.org/wiki/Emercoin

  • bazar
  • coin
  • emc
  • lib

@sleevi
Copy link
Contributor Author

sleevi commented Jan 16, 2017 via email

@dnsguru
Copy link
Member

dnsguru commented Jan 16, 2017

@galeksandrp Totally appreciate that you're wanting to help us maintain a complete list and that is most certainly appreciated.

Perhaps to build on sleevi's comment regarding ICP-3, the only reason that .onion is being considered as a valid candidate for PSL in exception to flowing through ICANN / IANA (the ICP-3) is that .Onion did go through the IETF vetting process and was published as an Internet RFC.

This is a necessary step to avoid arbitrary creation of conflicts with potential future TLDs, to allow appropriate review and vetting processes to reduce the likelihood of causing technical or security issues.

Those TLDs which suggested for inclusion would need to flow through the next ICANN round of TLDs or be vetted in a similar manner to .Onion (or .Example or .Local as other examples) at very least to be considered.

@weppos
Copy link
Member

weppos commented Jan 17, 2017

I apologize for the delay, I was travelling.

I don't have any specific objections to add .onion. However, I'd be interested to know if it may introduce any possible edge cases as I know some consumers are using the PSL to validate ICANN/IANA TLDs.

I specifically recall a discussion involving Let's Encrypt, hence it may be interesting to get a feedback from them. @jsha would the addition of a TLD like .onion add any side effect to the current use of the PSL in Let's Encrypt? I'm not saying that this will be used as the sole feedback to include or reject it, but I'd like to get some extra external feedback.

@sleevi @dnsguru as far as I understood, you are suggesting to add it to the PRIVATE section. Is that correct?

@sleevi
Copy link
Contributor Author

sleevi commented Jan 17, 2017 via email

@weppos
Copy link
Member

weppos commented Jan 17, 2017

@sleevi one of the possible advantages I can see of using the PRIVATE section, is that most libraries exposes the ability to disable the use of the private section. That would provide an extra compatibility layer that makes it possible to ignore .ONION if needed.

It's also true that .ONION domains are currently already implicitly defined by the * rule, but again clients may treat that rule differently and having an explicit .ONION entry in ICANN could possibly result into side effect.

As a library maintainer, I think @rockdaboot may also have some feedback.

@sleevi
Copy link
Contributor Author

sleevi commented Jan 17, 2017 via email

@weppos
Copy link
Member

weppos commented Jan 17, 2017

Any thoughts on how we go from superstition to safety though?

I'd wait a couple of days for @jsha and @rockdaboot to chime in, to see if they have any specific feedback. After that, I'm fine to go ahead and then deal with that if anything specific will came out.

@rockdaboot
Copy link
Contributor

@weppos Currently, I do not know of any real usage of sections. I implemented cookie domain checking with libpsl for curl, wget and wget2 with section==ANY (ICANN or PRIVATE).
So, for all the real use cases I know of, it would not matter where you put .onion. It wouldn't even matter if you don't put .onion into the PSL (* rule).
Sorry for no being much of a help.

@weppos
Copy link
Member

weppos commented Jan 17, 2017

@rockdaboot that's fine, it is actually a feedback 😉

@jsha
Copy link

jsha commented Jan 17, 2017

Adding .onion in either section is fine from Let's Encrypt's perspective. We will add .onion to our explicit list of domains never to issue, just as a second check on top of the fact that no .onion domain should resolve on the non-Tor Internet. There's no timing constraint here since we vendor the PSL.

@weppos
Copy link
Member

weppos commented Jan 18, 2017

Thanks for the feedback @jsha.

@sleevi at this point, it's a 👍 to me too. I don't have strong arguments for now to have it in PRIVATE vs non-PRIVATE.

I would be ok to add it to ICANN and then move it PRIVATE if needed.

sleevi added a commit that referenced this issue Jan 18, 2017
While "onion" does not appear within the root zone database, per RFC 7686, it is set aside as a special-use domain name, and explicitly called out as suitable for inclusion by IANA within the root zone database. Unlike other special-use domain names at this time, onion names that comply with RFC 7686 meet the definition of ICP-3 for both community process and a globally unique namespace (through being bound to keys in a process that ensures two clients end up with the same resolution).

Closes #374
@sleevi sleevi mentioned this issue Jan 18, 2017
sleevi added a commit that referenced this issue Jan 18, 2017
While "onion" does not appear within the root zone database, per RFC 7686, it is set aside as a special-use domain name, and explicitly called out as suitable for inclusion by IANA within the root zone database. Unlike other special-use domain names at this time, onion names that comply with RFC 7686 meet the definition of ICP-3 for both community process and a globally unique namespace (through being bound to keys in a process that ensures two clients end up with the same resolution).

Closes #374
rolandshoemaker pushed a commit to letsencrypt/boulder that referenced this issue Feb 7, 2017
In the last weeks we made some large changes to the list of .RU and .SU domains in the PSL, due to some very old policy changes at the registry (2009) and more recent follow up.

Given the amount of pressure about these changes from certain users, most certainly because LE limits, I figured out you'll soon have people asking you to merge the changes. I've packaged a new release of publicsuffix-go, and updated the dependency in this PR.

$ git show master

commit c5490f26d8f43b84857ac54e23387b8ed9b100dd
Author: Simone Carletti <[email protected]>
Date:   Tue Feb 7 23:26:14 2017 +0100

    Release 0.3.2
➜  publicsuffix-go git:(master) go test ./...
?   	github.com/weppos/publicsuffix-go/cmd/load	[no test files]
ok  	github.com/weppos/publicsuffix-go/net/publicsuffix	0.023s
ok  	github.com/weppos/publicsuffix-go/publicsuffix	0.039s

Please note this release also includes the .ONION as per publicsuffix/list#374
@dnsguru dnsguru mentioned this issue May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants