Adjust previews so marked person is visible

[illnesse]

Example: marked person isn't visible in preview, only in full view, but then there's no green rectangle and you can't be sure which face is being referenced:

Basically we need to make sure the green rectangle is visible in previews, sounds like a lot of fun math 😅 not sure how I'd do it, maybe something like this..

• check if all 4 corners are in view
• if not -> adjust view so they are (with some min padding to the edge)
• if green rectangle/face is cut off in photo -> do more math idk 🙋

[pulsejet]

Did you run occ memories:index -f after upgrading to v4.3? Or is this on mobile?

[illnesse]

Screenshot is from mobile, what does the -f do? I haven't ran index for a while

[pulsejet]

Makes sense. Not sure how this could be fixed though; let's see.

You need to run index after the 4.3 update because exiftool also stores the image size now (needed for the tiled layout). -f forces a re-run and indexes all images.

[illnesse]

Ok it's doing its thing now.
I got this:
Exiftool not found: /var/www/nextcloud/apps/memories/lib/../exiftool-bin/exiftool/exiftool
Exiftool not found: /var/www/nextcloud/apps/memories/lib/../exiftool-bin/exiftool-amd64-glibc
But guess it found it elsewhere
Also a few random Exiftool may have crashed, restarting process but seems fine

[pulsejet]

Weird. Are you running off git or installed from the app store?

[illnesse]

git actually but nextcloud forced me to update from the store as well

whereis exiftool
exiftool: /usr/bin/exiftool

[pulsejet]

Then you need to run make exiftool to download exiftool first. Memories ships with it's own version now.

[illnesse]

Thanks, better now, ill test the layout when it's done indexing 👍🏼

[illnesse]

That fixed it

[illnesse]

Just to make sure, mobile always has the square layout right? So this issue actually still exists on mobile. But low priority imo, as long as desktop works

[sirdrakeistda]

Just to make sure, mobile always has the square layout right? So this issue actually still exists on mobile. But low priority imo, as long as desktop works

Can you show an image how it should look? I've never seen a green rectangle, neither on desktop or mobile.

[illnesse]

Can you show an image how it should look? I've never seen a green rectangle, neither on desktop or mobile.

You need to tick the box in the menu in the upper right

[sirdrakeistda]

There is no box for me in the upper right. There is the option to merge or remove persons. The only checkbox I see is the checkbox for every image. Activating this does not show a rectangle for me.

[pulsejet]

@sirdrakeistda To be sure, is this activated? #79 (comment)
Also you need to refresh the page after ticking that.

[sirdrakeistda]

I'm confused at the moment. Are memories and recognize two different apps? I only installed recognize (because only this app was suggested in the photo app).
nextcloud/recognize#429 (comment)

[pulsejet]

Are memories and recognize two different apps?

Umm yeah. https://apps.nextcloud.com/apps/memories
Memories is a separate photo viewer like Photos that also uses faces from the recognize app.

[pulsejet]

Thumbs aren't cropped anymore 🎉