Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicator in preview which face in the image is being referenced #79

Closed
illnesse opened this issue Oct 18, 2022 · 6 comments
Closed

Indicator in preview which face in the image is being referenced #79

illnesse opened this issue Oct 18, 2022 · 6 comments
Labels
feature New feature or request

Comments

@illnesse
Copy link

illnesse commented Oct 18, 2022

Maybe thumbnail of the face in a corner, picture-in-picture, or maybe draw a rectangle etc? So if you have pictures of couples or a group shot of multiple people you know if the right face is in the right cluster etc. Again no idea if that's in your ballpark or @marcelklehr 's. If we don't want to touch the preview image, it could probably easily be done with css as overlay with a 32x32 face or div border marking the detected face within the photo, if we have the rect info

@pulsejet
Copy link
Owner

pulsejet commented Oct 18, 2022

As I mentioned in the other issue, this really belongs to viewer. One idea that comes to mind is to show the name of the face on hovering on the face (and allow changing it there maybe). We do have the rect, so this just needs a call to recognize from the viewer.

One possible ugly way to do this here without waiting on viewer would be registering an overriding handler for images with the viewer. Might serve as a good POC though.

EDIT: Hmm, I read something wrong. Drawing a rectangle on the timeline is definitely for memories. Of course that'll have to be an option, but I agree this sounds pretty useful especially on desktop. In that case, we can also have an option to directly move this particular face identification to another cluster. Very useful!

@pulsejet pulsejet added the feature New feature or request label Oct 18, 2022
@pulsejet
Copy link
Owner

@illnesse is this what you're talking about?
image

@illnesse
Copy link
Author

illnesse commented Oct 18, 2022

Drawing a rectangle on the timeline

this. Especially useful while cleaning up clusters, and yes that looks pretty good already 👍🏻

pulsejet added a commit that referenced this issue Oct 18, 2022
@pulsejet
Copy link
Owner

image

@illnesse
Copy link
Author

That was quick! 🚀
I can see now there are so many faces in the wrong clusters here, hopefully classification gets better in the future if the clusters are more precise

@pulsejet
Copy link
Owner

Yeah, it's not super accurate. Not the worst either, though. Personally I don't use it in production yet because of missing HEIC support; I added just a few days back with nextcloud/recognize#365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants