-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HEIC/HEIF/TIFF #365
Conversation
Convert all images to JPEG and downscale before passing to node Signed-off-by: Varun Patil <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
@pulsejet Thanks a lot! Would you allow me to push some commits? |
@marcelklehr of course! I think you already should be able to. |
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
$imagick = new \Imagick($path); | ||
$imagick->scaleImage(4096, 4096, true); | ||
$dimensions = $imagick->getImageGeometry(); | ||
if ($dimensions['width'] > 4096 || $dimensions['height'] > 4096) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Imagick before 3.0.0 used to leave the image untouched if it was smaller than the specified scaling; I didn't know the behavior had changed.
Thank you @marcelklehr! 🎉 |
Convert all images to JPEG and downscale before passing to node
#233 #111