Allow running upgrade-provider if there is no associated GH release #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
reviewed
Mar 13, 2024
| var latestReleaseVersion = stepv2.Func11E("Latest Release Version", | ||
| func(ctx context.Context, repo string) (*semver.Version, error) { | ||
| var latestReleaseVersion = stepv2.Func12E("Latest Release Version", | ||
| func(ctx context.Context, repo string) (*semver.Version, bool, error) { |
There was a problem hiding this comment.
If a release was found. It's equivalent to checking if the *semver.Version is nil, but that felt like a footgun for go. Generally, for (*T, error), I assume that error == nil <=> *T != nil
t0yv0
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #254