Add needs release arg #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
reviewed
May 9, 2024
| @@ -256,6 +256,8 @@ This is equivalent to setting PULUMI_MISSING_DOCS_ERROR=${! VALUE}.`) | |||
| cmd.PersistentFlags().StringVar(&context.PRTitlePrefix, "pr-title-prefix", "", | |||
| `The prefix to insert in the generated pull request title.`) | |||
|
|
|||
| cmd.PersistentFlags().BoolVar(&context.NeedsReleasePatch, "needs-release-patch", false, "setting this field to True will trigger a patch release after the PR is merged.") | |||
There was a problem hiding this comment.
Instead of --needs-release-patch=true, can we have an enum flag --needs-release=patch.
| @@ -345,7 +345,11 @@ var InformGitHub = stepv2.Func70E("Inform Github", func( | |||
| } | |||
| // On non-upstream upgrades, we will create a patch release label | |||
| // if the provider hasn't been released in 8 weeks. | |||
| case c.MaintenancePatch && !c.UpgradeProviderVersion: | |||
| case (c.MaintenancePatch && !c.UpgradeProviderVersion): | |||
There was a problem hiding this comment.
We don't need this change.
Suggested change
| case (c.MaintenancePatch && !c.UpgradeProviderVersion): | |
| case c.MaintenancePatch && !c.UpgradeProviderVersion: |
| addLabels = []string{"--label", "needs-release/patch"} | ||
|
|
||
| // If we have the needs release flag, we make a patch release. | ||
| case c.NeedsReleasePatch: |
There was a problem hiding this comment.
We should put c.NeedsReleasePatch before the normal release switch statement. Otherwise we could get a scenario where the case c.UpgradeProviderVersion && len(target.GHIssues) > 0: branch triggers but no label is added, even though c.NeedsReleasePatch is true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to trigger releases of all providers on a bridge release.