Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tag objects when tags are listed for remote repos #274

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Aug 19, 2024

Correctly handle tag objects when parsing upstream semver tags.

This is very similar to what we do for patched providers:

version = strings.TrimSpace(strings.TrimSuffix(strings.TrimPrefix(ref, "refs/tags/"), "^{}"))

Fixes pulumi/pulumi-nomad#398

@iwahbe iwahbe self-assigned this Aug 19, 2024
@iwahbe iwahbe requested a review from a team August 19, 2024 08:45
@iwahbe iwahbe enabled auto-merge (squash) August 19, 2024 08:45
@iwahbe iwahbe merged commit 843f4ef into main Aug 19, 2024
2 checks passed
@iwahbe iwahbe deleted the iwahbe/handle-tag-commits branch August 19, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: Check upstream upgrade
2 participants