Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear examples cache during major upgrades #275

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

guineveresaenger
Copy link
Contributor

@guineveresaenger guineveresaenger commented Aug 19, 2024

Update: Apologies for the delay here; see pulumi/pulumi-terraform-bridge#2323.

pulumi/pulumi-confluentcloud#559 failed because the upgrade process was using an old examples cache locally.
As a result, the Go SDK was generated with old version paths in the examples code, which failed the Clean Worktree check.
The upgrade-provider tool should remove the cache to ensure we're generating examples correctly.

@t0yv0
Copy link
Member

t0yv0 commented Aug 19, 2024

Suggest fixing in the bridge instead since some interaction happens via make tfgen instead of via upgrade-provider, that'd be more definitive.

@guineveresaenger
Copy link
Contributor Author

@t0yv0 - reasonable! I see you found pulumi/pulumi-terraform-bridge#2323 already.

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable for a short-term fix, if we can't land a fix to the cache key in the next couple of weeks

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd much rather prioritize adding the major version to the cache in the bridge then fix it here. Unless this problem comes up regularly, I would suggest just fixing the bridge.

If you do need to merge, please add a TODO linking the step to the bridge bug.

@t0yv0
Copy link
Member

t0yv0 commented Aug 20, 2024

I'm with Daniel, ship the workaround. We'll fix the root cause later.

@guineveresaenger guineveresaenger merged commit 0cd89e1 into main Sep 13, 2024
2 checks passed
@guineveresaenger guineveresaenger deleted the guin/remove-cache branch September 13, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants