Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Increase max text length for controller text setting #683

Open
wants to merge 1 commit into
base: develop-pros-4
Choose a base branch
from
Open

🐛 Increase max text length for controller text setting #683

wants to merge 1 commit into from

Conversation

ion098
Copy link

@ion098 ion098 commented Jun 28, 2024

Summary:

Changes max length of controller text to 31 characters.

Motivation:

VEXCode allows users to set controller text with a maximum length of 31 characters, but PROS caps controller text at 15 characters.

References (optional):

Close #679

Test Plan:

  • Check it compiles
  • Check that controller text setting works with strings up to 31 characters long
  • Check that this doesn't break controller text clearing

@noam987
Copy link
Contributor

noam987 commented Jun 28, 2024

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BennyBot
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ion098 @noam987 @BennyBot