✨ Add rotation constructor with reversed flag #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BennyBot
requested changes
Jul 5, 2024
| } | ||
| Rotation::Rotation(const std::int8_t port) : Rotation(abs(port), port < 0) {} | ||
|
|
||
| Rotation::Rotation(const std::uint8_t port, const bool reversed): Device(port, DeviceType::rotation) { |
There was a problem hiding this comment.
Suggested change
| Rotation::Rotation(const std::uint8_t port, const bool reversed): Device(port, DeviceType::rotation) { | |
| Rotation::Rotation(const std::int8_t port, const bool reversed): Device(abs(port), DeviceType::rotation) { |
in the case the user provides a negative number and specifies the reverse flag, the reverse flag should be used.
| * } | ||
| * \endcode | ||
| */ | ||
| Rotation(const std::uint8_t port, const bool reversed); |
There was a problem hiding this comment.
Suggested change
| Rotation(const std::uint8_t port, const bool reversed); | |
| Rotation(const std::int8_t port, const bool reversed); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a rotation sensor constructor that takes a reversed flag.
Motivation:
Some people prefer using a reversed flag instead of negative port numbers.
Test Plan: