-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perhaps controversial: some qemu startup fixes #3
base: main
Are you sure you want to change the base?
Conversation
1. add rng device 2. use readonly virtfs mount 3. use nographics 4. do not use virtio-net Signed-off-by: Serge Hallyn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And since we're touching the QEMU command line bits, did we already drop the nic from QEMU_CMD_CORE and add it to the invocation of of qemu-full ?
-nodefaults \ | ||
$(NOGUI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've -nodefaults in the QEMU_CMD_CORE and in NOGUI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to pull that out of NOGUI. But where do you think it belongs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to pull that out of NOGUI. But where do you think it belongs?
QEMU_CMD_CORE
@@ -67,6 +67,9 @@ OVMF_DIR ?= $(shell for d in $(OVMF_SEARCH); do [ -d "$$d" ] && break; done; ech | |||
OVMF_CODE = $(OVMF_DIR)/OVMF_CODE.secboot.fd | |||
OVMF_VARS = $(OVMF_DIR)/OVMF_VARS.fd | |||
|
|||
NOGUI = -nodefaults \ | |||
-device VGA -vnc :9000 -serial mon:stdio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use regular vnc ports: -vnc :1
or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. And I guess I need a copy of my next-unused-vnc-port script in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd switch NOGUI name to VNC and move the -serial mon:stdio to the QEMU_CMD_CORE
Does this mean that you feel qemu-full requires it? |
Not necessarily. It' possible that if things were expanded to test networking function in UEFI firmware that we'd want to have a nic; I think primarily the issue seen was booting with the nic included forced a PXE timeout when no one wanted to wait on that. So if this change solves not getting stuck waiting for PXE to do qemu-esp |
Indeed it does. But, did your sentence get cut off? |
sigh Yes. Finishing the thought, if we're not blocking on PXE during boot, then we can always add a nic back in to which ever target (qemu-full or a new one qemu-net) when that's needed. Thanks. |
I'm no longer using this, a-vm-builder being a better alternative. So we can close this unless someone wants it. Hopefully we can post the alternative (a-vm-builder) soon. |
@hallyn have you a link to the "a-vm-builder"? |
Argh - sorry, as I said "hopefully we can post it soon". It's an internal project which everyone has been agreed should be open sourced for the past 5 years, but we've not done the final push. Let me see if I can get that moment going, but as I'd said if someone does want this in the meantime, then we shouldn't drop it after all. |
Signed-off-by: Serge Hallyn [email protected]