Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perhaps controversial: some qemu startup fixes #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hallyn
Copy link
Contributor

@hallyn hallyn commented Aug 30, 2021

  1. add rng device
  2. use readonly virtfs mount
  3. use nographics
  4. do not use virtio-net

Signed-off-by: Serge Hallyn [email protected]

1. add rng device
2. use readonly virtfs mount
3. use nographics
4. do not use virtio-net

Signed-off-by: Serge Hallyn <[email protected]>
Copy link

@raharper raharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And since we're touching the QEMU command line bits, did we already drop the nic from QEMU_CMD_CORE and add it to the invocation of of qemu-full ?

Comment on lines +93 to +94
-nodefaults \
$(NOGUI)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've -nodefaults in the QEMU_CMD_CORE and in NOGUI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to pull that out of NOGUI. But where do you think it belongs?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to pull that out of NOGUI. But where do you think it belongs?

QEMU_CMD_CORE

@@ -67,6 +67,9 @@ OVMF_DIR ?= $(shell for d in $(OVMF_SEARCH); do [ -d "$$d" ] && break; done; ech
OVMF_CODE = $(OVMF_DIR)/OVMF_CODE.secboot.fd
OVMF_VARS = $(OVMF_DIR)/OVMF_VARS.fd

NOGUI = -nodefaults \
-device VGA -vnc :9000 -serial mon:stdio

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use regular vnc ports: -vnc :1 or something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably. And I guess I need a copy of my next-unused-vnc-port script in here.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd switch NOGUI name to VNC and move the -serial mon:stdio to the QEMU_CMD_CORE

@hallyn
Copy link
Contributor Author

hallyn commented Aug 30, 2021

And since we're touching the QEMU command line bits, did we already drop the nic from QEMU_CMD_CORE and add it to the invocation of of qemu-full ?

Does this mean that you feel qemu-full requires it?

@raharper
Copy link

And since we're touching the QEMU command line bits, did we already drop the nic from QEMU_CMD_CORE and add it to the invocation of of qemu-full ?

Does this mean that you feel qemu-full requires it?

Not necessarily. It' possible that if things were expanded to test networking function in UEFI firmware that we'd want to have a nic; I think primarily the issue seen was booting with the nic included forced a PXE timeout when no one wanted to wait on that. So if this change solves not getting stuck waiting for PXE to do qemu-esp

@hallyn
Copy link
Contributor Author

hallyn commented Aug 30, 2021

So if this change solves not getting stuck waiting for PXE to do qemu-esp

Indeed it does. But, did your sentence get cut off?

@raharper
Copy link

So if this change solves not getting stuck waiting for PXE to do qemu-esp

Indeed it does. But, did your sentence get cut off?

sigh Yes. Finishing the thought, if we're not blocking on PXE during boot, then we can always add a nic back in to which ever target (qemu-full or a new one qemu-net) when that's needed.

Thanks.

@hallyn
Copy link
Contributor Author

hallyn commented Oct 31, 2021

I'm no longer using this, a-vm-builder being a better alternative. So we can close this unless someone wants it.

Hopefully we can post the alternative (a-vm-builder) soon.

@berlin4apk
Copy link

@hallyn have you a link to the "a-vm-builder"?
My Google search are unsuccessful

@hallyn
Copy link
Contributor Author

hallyn commented Apr 7, 2022

@hallyn have you a link to the "a-vm-builder"? My Google search are unsuccessful

Argh - sorry, as I said "hopefully we can post it soon". It's an internal project which everyone has been agreed should be open sourced for the past 5 years, but we've not done the final push.

Let me see if I can get that moment going, but as I'd said if someone does want this in the meantime, then we shouldn't drop it after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants