Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove PSYGNAL_UNCOMPILED flag. #183

Merged
merged 10 commits into from
Feb 21, 2023

Conversation

tlambert03
Copy link
Member

the PSYGNAL_UNCOMPILED flag tries to allow the user to run psygnal in an uncompiled version by screwing with the import system.

It's buggy and problematic. This removes it and adds two utility functions decompile and recompile. All they do is rename the .so/.pyd files so as to make them unusuable/usable.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (2179ebc) compared to base (aecc202).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         1542      1536    -6     
=========================================
- Hits          1542      1536    -6     
Impacted Files Coverage Δ
src/psygnal/__init__.py 100.00% <100.00%> (ø)
src/psygnal/_evented_decorator.py 100.00% <100.00%> (ø)
src/psygnal/utils.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 21, 2023

CodSpeed Performance Report

Merging #183 uncompiled (2179ebc) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 58 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@tlambert03 tlambert03 merged commit 108000c into pyapp-kit:main Feb 21, 2023
@tlambert03 tlambert03 deleted the uncompiled branch February 21, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant