Connet set attribute to signal (alternate) #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 355 405 +50
=========================================
+ Hits 355 405 +50
Continue to review full report at Codecov.
|
Czaki
commented
Nov 7, 2021
psygnal/_signal.py
Outdated
Comment on lines
1036
to
1084
| class PartialWeakrefCallback: | ||
| def __init__(self, slot_partial: PartialMethod): | ||
| self.obj, self.name = _get_proper_name(slot_partial.func) | ||
| self.args = slot_partial.args | ||
| self.kwargs = slot_partial.keywords | ||
|
|
||
| def alive(self) -> bool: | ||
| return self.obj() is not None | ||
|
|
||
| def __call__(self, *args: Any, **kwargs: Any) -> Any: | ||
| return getattr(self.obj(), self.name)( | ||
| *self.args, *args, **self.kwargs, **kwargs | ||
| ) | ||
|
|
||
| def __eq__(self, other: Any) -> bool: | ||
| try: | ||
| return ( | ||
| isinstance(other, PartialWeakrefCallback) | ||
| and self.name == other.name | ||
| and self.obj() == other.obj() | ||
| and self.args == other.args | ||
| and self.kwargs == other.kwargs | ||
| ) | ||
| except: # noqa: E722 | ||
| return False | ||
|
|
||
|
|
||
| class PropertyWeakrefCallback: | ||
| def __init__(self, obj: Union[weakref.ref, object], name: str): | ||
| if not isinstance(obj, weakref.ref): | ||
| obj = weakref.ref(obj) | ||
| self.obj = obj | ||
| self.name = name | ||
|
|
||
| def alive(self) -> bool: | ||
| return self.obj() is not None | ||
|
|
||
| def __call__(self, *args: Any) -> None: | ||
| if len(args) == 1: | ||
| setattr(self.obj(), self.name, args[0]) | ||
| else: | ||
| setattr(self.obj(), self.name, args) | ||
|
|
||
| def __eq__(self, other: Any) -> bool: | ||
| return ( | ||
| isinstance(other, PropertyWeakrefCallback) | ||
| and self.name == other.name | ||
| and self.obj() == other.obj() | ||
| ) |
There was a problem hiding this comment.
I decide to switch to class to allow compare two objects
tlambert03
changed the title
|
merged #39, so converted this to draft. Some nice class patterns in here that we should remember. perhaps we can figure out the performance stuff later and use it then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #36