Ensure StaticFiles doesn't break instrument_fastapi (#294)

pydantic · Jul 1, 2024 · cdb879b · cdb879b
1 parent 770780d
commit cdb879b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/logfire/_internal/integrations/fastapi.py b/logfire/_internal/integrations/fastapi.py
@@ -36,8 +36,9 @@ def find_mounted_apps(app: FastAPI) -> list[FastAPI]:
     for route in app.routes:
         if isinstance(route, Mount):
             _app: Any = route.app
-            mounted_apps.append(_app)
-            mounted_apps += find_mounted_apps(_app)
+            if isinstance(_app, FastAPI):
+                mounted_apps.append(_app)
+                mounted_apps += find_mounted_apps(_app)
     return mounted_apps
 
 

diff --git a/tests/otel_integrations/test_fastapi.py b/tests/otel_integrations/test_fastapi.py
@@ -11,6 +11,7 @@
 from fastapi.exceptions import RequestValidationError
 from fastapi.params import Header
 from fastapi.security import SecurityScopes
+from fastapi.staticfiles import StaticFiles
 from inline_snapshot import snapshot
 from opentelemetry.propagate import inject
 from starlette.requests import Request
@@ -75,6 +76,7 @@ def app():
     app = FastAPI()
     first_lvl_app = FastAPI()
     second_lvl_app = FastAPI()
+    app.mount('/static', StaticFiles(), name='static')  # https://github.com/pydantic/logfire/issues/288
     app.mount('/first_lvl', first_lvl_app)
     first_lvl_app.mount('/second_lvl', second_lvl_app)