Enhancement/164/coupled action #217
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will need to compute coupling first
will need to pass coulping result into action calculation
mihofer
reviewed
Sep 9, 2020
| @@ -78,14 +78,26 @@ def _getkick(measure_input, files, plane): | |||
| return kick_frame | |||
|
|
|||
|
|
|||
| def _gen_kick_calc(meas_input, lin, plane): | |||
| def _gen_kick_calc(meas_input, lin, plane, coupling=None): | |||
There was a problem hiding this comment.
add header in argument to put a flag there if correction was applied?
|
Code Climate has analyzed commit dc9d278 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 37.5% (50% is the threshold). This pull request will bring the total coverage in the repository to 85.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces correction to coupling in action calculation. For the moment waits for coupling module to be finished and lacks a test.