add get_bad_bpms #427
add get_bad_bpms #427
Conversation
There was a problem hiding this comment.
Details here and there. I'm open to contributing about them if you would like.
I'm wondering if this should be included in omc3 itself. Maybe this is a good fit for pylhc? Would like @JoschD's opinion.
Also, in hindsight to my review in #pylhc/py, I like the little purpose paragraph you have in this PR. Maybe it could be copy-pasted or adapted there?
| 1. Make sure that the measurements have the desired cleaning method applied. | ||
| If needed rerun the measurements with the GUI. | ||
|
|
||
| 2. Adapt the `DATES` list at the beginning of this script accordingly |
There was a problem hiding this comment.
I would rather see this as a script input, either as a complete list of dates or as a low and high date range. If this is part of a package anyway then people are not going to install it in editable mode just to modify hard-coded places.
| import pathlib | ||
| import tfs | ||
|
|
||
| ROOT = pathlib.Path("./Betabeat/") |
There was a problem hiding this comment.
I would rather make the default ROOT as the current working directory (pathlib.Path.cwd()), so you can just cd wherever and then invoke the script.
| OUTFILE = None | ||
|
|
||
| def main(): | ||
| global OUTFILE |
There was a problem hiding this comment.
I feel like global is not a good look, we can pass arguments.
|
|
||
| OUTFILE.close() | ||
|
|
||
| def bad_bpms_per_date(date: pathlib.Path, plane: str, beam: str): |
There was a problem hiding this comment.
Here date: pathlib.Path feels counter-intuitive, maybe folder?
There was a problem hiding this comment.
Also as the two inner functions, we're not sending back the bad BPMs per se but rather the files listing BPMs.
|
|
||
| measurements = [p for p in meas.iterdir() if p.is_dir()] | ||
|
|
||
| def get_bad_bpms(path: pathlib.Path): |
There was a problem hiding this comment.
This is more get_bad_bpms_file
| return m | ||
| return None | ||
|
|
||
| def get_iforest_bpms(path: pathlib.Path): |
| measurements_iforest = [p for p in measurements_iforest if p is not None] | ||
| return (measurements_svd, measurements_iforest) | ||
|
|
||
| def get_bad_bpms_for_beam_and_plane_svd(date: str, plane: str, beam: str, bad_bpms_list): |
There was a problem hiding this comment.
Feels like bad_bpms_list is not expecting a list
| bad_bpms_list[words[0]] = 1 | ||
| return len(measurements) | ||
|
|
||
| def get_bad_bpms_for_beam_and_plane_iforest(date: str, plane: str, beam: str, bad_bpms_list): |
New Feature
This script collects a list of all BPMs declared as bad by either SVD cleaning or isolation forest and compiles a list with number of occurances for each BPM that has been declared at least 50% (25%) of the time.
Purpose
Every now and then BI asks for a list of BPMs that cause trouble for our measurements so that they can take a closer look during the next (E?YET|L)S . This script is intended to facilitate the process of retrieving such a list.
Notes
This script is just a template, if specific measurements / globbing sounds better than just taking unchecked all the measurements in one (or several) output folder, feel free to adapt if necessary
I am not going to write tests for this. It's a script that's run once every 2-3 years.