Arc corr and glob check fix

[fscarlier]

It's all in a single pull request, since it was all entangled anyway:

changes:

• added arc-by-arc corrections
• added the fixes we made together
• changed the .json corrector files to include the mqt and ats only, and the 2024 global correction lists.
• Added the arc-by-arc-phase and include-ips to the global_corrections parameters input

Two things:

• Can you check if it is ok for the opt. definitions?
• One test seems to fail for macos, but it doesn't seem to be related to the changes.

[fsoubelet]

I believe @JoschD has a few refactors & tests in mind. In the meantime, a few comments / suggestions.

A little bit of type hinting could go a long way for the new functions in omc3/correction/arc_by_arc.py

[fsoubelet]

Could use the constants instead of the hard-coded PHASEX.

[fscarlier]

True, I wasn't aware of the constants when I coded this.

[fsoubelet]

The codebase is in an in-between with some hardcoded stuff still and some constants use, but for new code let's try to keep to the good way :P

[JoschD]

Hey @fscarlier . This still needs tests, have you progressed in that regard?

[JoschD]

Hey @fscarlier . It would be great if you could implement some tests, so we can merge this back into master and avoid the clusterfudge we had last year with diverging branches.

[codeclimate]

Code Climate has analyzed commit 51c2400 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	2

The test coverage on the diff in this pull request is 42.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 85.4% (-0.5% change).

View more on Code Climate.

[JoschD]

Hey @fscarlier what is the status of these tests? Have you talked to @emaclean or @rogeliotomas that maybe someone else can take over this task if this cannot be done by you?