False positive unreachable-code when using typing.Any as return in python 3.8
#9753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pierre-Sassoulas
force-pushed
the
fix-regression-9751
branch
from
51f67e2
to
6017597
Compare
This comment has been minimized.
This comment has been minimized.
1 task
|
Looks good, happy to approve once the functional tests are altered for 3.8 |
Refs #9751 Co-authored-by: John Snow <[email protected]>
Pierre-Sassoulas
force-pushed
the
fix-regression-9751
branch
from
6017597
to
549eb4d
Compare
|
Thank you for the review. I wanted to validate the approach before committing to refactoring the functional tests. (wondered if you wanted to fix python 3.8). Should be mergeable now, What do you think about releasing 3.2.5 directly with only this ? It's a regression and there's a lot of traffic on #9751 |
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #9753 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 174 174
Lines 18878 18878
=======================================
Hits 18094 18094
Misses 784 784
|
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 549eb4d |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
Refs #9751 Co-authored-by: John Snow <[email protected]> (cherry picked from commit d281f2f)
Pierre-Sassoulas
added a commit
that referenced
this pull request
Jun 28, 2024
Refs #9751 Co-authored-by: John Snow <[email protected]> (cherry picked from commit d281f2f) Co-authored-by: Pierre Sassoulas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #9751 regression introduced in #9714 by c41c35a