Search all distributions when trying to find a match in get_distribution() #8702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches the behavior of pkg_resources.get_distribution(), which this function intends to replace.
The call to get_installed_distributions() now passes all flags excplicitly so they are more obvious and less likely to be misunderstood in the future. The behavior also documented in the function docstring. The search_distribution() helper function is renamed with a leading underscore to make it clear that it is intended as a helper function to get_distribution().
uranusjr
commented
Aug 4, 2020
| @@ -140,6 +140,7 @@ def print_results(hits, name_column_width=None, terminal_width=None): | |||
| write_output(line) | |||
| if name in installed_packages: | |||
| dist = get_distribution(name) | |||
| assert dist is not None | |||
There was a problem hiding this comment.
This whole module is using the distribution-related functions in a very inprecise way. I’ll submit a standalone refactoring PR after this is accepted
sbidoul
approved these changes
Aug 5, 2020
|
@pradyunsg I took the liberty to create milestone 20.2.2 |
Me either, non-local site-packages are difficult to test, for obvious reasons. I’ll take a look later and see whether existing tests can offer some inspiration. |
|
I added a couple of tests for this. |
|
When is 20.2.2 going to be released? A regression in pip is really impactful to the community and can not be left hanging for days on end. |
See #8511 (comment). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8695. I also made some minor refactoring so we can better avoid this kind of behavioural mistakes in the future.