Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for Python 3.5 #8778

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Aug 18, 2020

In #8181 (comment), it looks like there's consensus for dropping Python 3.5 in pip 21.0 (January 2021).

As has been done previously, this adds a deprecation warning when running pip on Python 3.5.

It's not urgent, but this could be included in tomorrow's 20.2.3 release (#8511 (comment)), which would give two more months of warning than waiting for pip 20.3 in October.

If so, need to change the message from past to future tense, for example:

-                "Python 3.5 reached the end of its life on September "
+                "Python 3.5 will reach the end of its life on September "
                 "13th, 2020. Please upgrade your Python as Python 3.5 "
-                "is no longer maintained. pip 21.0 will drop support "
-                "for Python 3.5 in January 2021."
+                "won't be maintained after September 2020. pip 21.0 will "
+                "drop support for Python 3.5 in January 2021."

Also updated gone_in for 2.7 (#6148 (comment)).

@pradyunsg pradyunsg merged commit b7075b9 into pypa:master Aug 25, 2020
@pradyunsg pradyunsg added this to the 20.2.3 milestone Aug 25, 2020
@hugovk hugovk deleted the deprecate-3.5 branch August 25, 2020 17:25
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Sep 8, 2020
Deprecate support for Python 3.5
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants