Cache found candidates #8912
Merged
Cache found candidates #8912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, I like this :-) |
|
Add the NEWS fragment, and we're good to go? :P |
|
Fragment added. I categorise this as a feature since it is (arguably) an improvement of something that already works, that just “happens” to also resolve a performance bug. |
uranusjr
force-pushed
the
cache-found-candidates
branch
from
1999d58
to
6eb9761
Compare
uranusjr
force-pushed
the
cache-found-candidates
branch
from
6eb9761
to
22eeff4
Compare
|
Hmm. Does the news bot not accept |
pfmoore
approved these changes
Sep 26, 2020
|
It should just be named |
Uhhhhhhhh... Looks like no. |
pradyunsg
approved these changes
Sep 27, 2020
This was referenced Oct 1, 2020
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Oct 12, 2020
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Oct 12, 2020
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Oct 16, 2020
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8905 (comment)