add tech_colors #1032
Closed
add tech_colors #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@energyLS please review! |
davide-f
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Hello :)
Clearly I leave comments to Leon; it seems that some entries are kind-of duplicated, basically the only difference is the capital letters and values are not consistent thorught the dictionary.
Is this something we should do after or before the merge in your opinion?
updates: - [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0) - [github.com/snakemake/snakefmt: v0.10.1 → v0.10.2](snakemake/snakefmt@v0.10.1...v0.10.2) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
@davide-f before the merge -> would need it for this notebook: pypsa-meets-earth/documentation#87 |
* reformatting * release_notes.rst update * modifications logger.info * changes to configuration.rst
* CSP integration into config files * rename cutout file for default config * update costs file to accomodate csp * added stores and links for csp * corrected bus for csp bus * renamed csp rows according to the technology repo * fixed shape issues in links addition to the network * added csp rows to the cost file * added heat buses * added bus and generator for csp * more config for csp * moved csp to extra components * added more config to csp renewable * revised csp config * revised csp config * fix for CI failing * renamed csp values * adjusted csp settings to csp-tower * fixed typo * added csp to the config for landlock * changed key for csp * adjusted csp naming * adjusted csp naming * renamed architecture * removed correction factor * add csp to docs * fix for how_to_docs * revert how to docs inclusion * removed csp from extendable carrier * adjusted capacity_per_sqkm value
|
@davide-f removed the double entries :) |
davide-f
reviewed
Jun 6, 2024
|
Closed in favor of #1037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes # (if applicable).
Changes proposed in this Pull Request
To get this running, we need some additional tech_colors in our config:
pypsa-meets-earth/documentation#87
Checklist
envs/environment.yamlanddoc/requirements.txt.config.default.yamlandconfig.tutorial.yaml.test/(note tests are changing the config.tutorial.yaml)doc/configtables/*.csvand line references are adjusted indoc/configuration.rstanddoc/tutorial.rst.doc/release_notes.rstis amended in the format of previous release notes, including reference to the requested PR.