-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: The search-again option breaks ytfzf #613
Comments
This should now be fixed in the development branch. |
Thank you! Since debian decided to package it, I no longer use it as another standalone script from my ~/bin folder. |
This patch should work on it's own. |
Thank you. I will patch it in ~15 minutes, because I have some work to do right now, and report back. |
It did not work :(
to
but the problem is still there. Can I clean the cache folder now? ---edit |
make sure to change the |
Can you please be more specific about that? I am not that experienced with bash :( |
You put this # doing this after the loop allows for -l and -s to coexist
while [ "$search_again" -eq 1 ] ; do
clean_up
initial_search=""
main
done You need to put this # doing this after the loop allows for -l and -s to coexist
while [ "$search_again" -eq 1 ] ; do
clean_up
init_and_make_search "" "prompt"
main
done The difference is that instead of just |
This is what I now have at the lines above
but it still behaves like before. I even removed the indents from the left side. |
do not put |
Ok this fixed it. I am posting my change again, just in case
There is a missing "=" after the word search on line 6. I do not know if it is important, I am only mentioning it. |
You can replace "prompt" on line 6, with "$search_source" if you want. I may add this to the main script as it makes more sense.
init_and_make_search is a function not a variable, there is no need for an |
Closing as fixed in 2.5.4. I did not notice it was released here 1 week ago, I was waiting for the the package update on my distro :( |
One thing I just noticed. The search again parameter seems to work only once. I launch |
oddly, yes it was hardcoded to only show the prompt with |
The 1+ month late reply :( |
All good, and yes this is fixed in 2.5.5 |
Thank you :) |
Describe the bug
The search-again option (either as a command line parameter or as a parameter in the configuration file) breaks ytfzf in a weird way. Once the playback, instead of returning to the results, it just returns to fzf "menu" which waits for input in a menu with zero entries! And the only way to exit it is to completely close the terminal.
Pressing ctrl+c shows what is behind fzf for a split second, and it mentions ~/.cache/ytfzf as far as I can read.
To Reproduce
--search-again
parameter.Expected behavior
Ytfzf should return to the list where fzf waits for user input. Fzf works like it should here, it just has nothing to display as a list.
Screenshots
Information
ls -l "$(which sh)"
(if you're using fish:ls -l (which sh)
):lrwxrwxrwx 1 root root 4 Sep 1 17:11 /usr/bin/sh -> dash
Additional context
Pictured above is alacritty, fzf is on v0.35, below is my conf.sh and ytfzf was working fine until 2.5.2.
Last but not least, I want to clean anything that is under the
~/.cache
folder, but I am keeping it for now, if it helps troubleshoot the issue.The text was updated successfully, but these errors were encountered: