-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add viewed date support #626
Conversation
- add the viewed date (in the end of the array by reversing with tac) on executing add_to_hist, format is "12/10/22 12:48:06 +1100" - make it viewable in the interface (only while checking history) - alter interface width to add space for viewed date adapted from pystardust@a74ca6c
I think, instead of adding a The reason I say this, is because the attributes that are present are not meant to necessarily represent one specific thing. For watch history we can just make date represent the watch date instead of upload date. Edit: |
I've experimented this before, if you add the date command in the attribute instead of the imo using the date attribute for viewed times as it is a bit misleading/unclear, will also break the interface as it'll show the supposed "viewed" dates when searching, unless you wanna also hide/remove the upload date altogether. I think it's an important feature to show how relevant a video is. I used
should I change the function? |
I think you misunderstood me. I am not saying we should redefine the This way we don't have to deal with the |
@Euro20179 ah I see. still, people still might want to use that metadata even if it's just for viewing history. I'm aware that youtube upload dates is relative but we should keep it in case we fix it to a normal date. I personally browse my history like a diary sometimes, just looking at the dates when I watch it and when it's uploaded is good for context. |
This is a good point. What I dont like is that this adds a special property just for the history scraper. So I have an idea. Im going to allow scrapers to create their own version of Please fix the use of |
@Euro20179 alright. should I remove the special property now or we'll deal with it later? I'll add a todo comment just in case |
Leave the special property, I'm gonna try my hand at integrating it in better. Just try to remove the use of |
ps: I think you have to request changes on your end for me to work on it |
using sed -z will have the same result as with tac. it'll add it in the end of the rows |
It doesnt need to be at the end, also I dont think the |
sorry, mild ocd |
lol, if you want it to be at the end then that's fine, just make sure its posix complient. |
I'll find a way later (if I do), this is alright. |
there is a weird behavior if you combine the two sed commands, it inserts on the third line normally, but if you use the it doesn't break anything though. but I'll undo this just to be sure. |
by the way, feel free to write your own |
adapted from a74ca6c
reminder that @pystardust might want to remove upload date altogether to make it less cluttered #171 (comment)
this is an old altered version I had lying around on my computer, seems like there is a lot that has changed since then. still working after a bit of modification. in the text interface the viewed date only shows the date and time, not the timezone but the timezone is shown in the thumbnail interface.
extra commands: date, tac. both are part of the GNU coreutils