next_page tabular tui did not know about COLUMNS AND LINES #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now pass them into environment as TTY_COLS and TTY_LINES and let the definition of COLUMNS and LINES fallback on those.
Introduce _init_video_info_text that sets the vars for tabular formatting before video_in_text and _post_video_info_text that uses column (if available) to format lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like
fzfdoes not pass those env variables when invoking reload(...) shells. That leads to messing up the tabular layout when in terminal and triggering a reload because then the default values 80 and 25 are assigned, which is different (in my case) from the actual available columns and lines.Pass
TTY_COLSandTTY_LINESto the env in reload(...) invocations ofytfzfand fallback to those values when defining from COLUMNS and LINES.Introduce private functions
_init_video_info_textand_post_video_info_textto be consistent in all invocations of reload(...) shells._init_video_info_text is passed
TTY_COLSas first param to account for difference betweeninterface_textandinterface_ext.