Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use oldest supported Python in mypy pre-commit checks #12747

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

nicoddemus
Copy link
Member

Follow up to #12744, this ensures type checking works at the oldest Python version supported by pytest.

@nicoddemus nicoddemus added the skip news used on prs to opt out of the changelog requirement label Aug 29, 2024
Follow up to pytest-dev#12744, this ensures type checking works at the oldest Python version supported by pytest.
@nicoddemus nicoddemus marked this pull request as ready for review August 29, 2024 12:05
@nicoddemus nicoddemus added the backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch label Aug 29, 2024
Copy link
Contributor

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@nicoddemus
Copy link
Member Author

Probably best to merge this after #12746, otherwise backporting will fail.

@nicoddemus nicoddemus merged commit 419bc7a into pytest-dev:main Aug 29, 2024
29 of 32 checks passed
Copy link

patchback bot commented Aug 29, 2024

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/419bc7a7c39d21af8a2b7cf29928ee93b7e02b19/pr-12747

Backported as #12750

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 29, 2024
Follow up to #12744, this ensures type checking works at the oldest Python version supported by pytest.

(cherry picked from commit 419bc7a)
nicoddemus added a commit that referenced this pull request Aug 29, 2024
Follow up to #12744, this ensures type checking works at the oldest Python version supported by pytest.

(cherry picked from commit 419bc7a)

Co-authored-by: Bruno Oliveira <[email protected]>
@nicoddemus nicoddemus deleted the mypy-use-old-python branch August 29, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.3.x apply to PRs at any point; backports the changes to the 8.3.x branch skip news used on prs to opt out of the changelog requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants