Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-111874: Call
__set_name__
on objects that define the method inside atyping.NamedTuple
class dictionary as part of the creation of that class #111876gh-111874: Call
__set_name__
on objects that define the method inside atyping.NamedTuple
class dictionary as part of the creation of that class #111876Changes from 7 commits
e3b703d
f053310
7ccff63
0d13e83
e4e968a
e0c88f0
d8102fd
f2a57b2
1909fd5
ed53fcb
c2c65c6
e79ea37
9fd8b6b
fdab495
3932d48
3359ff6
ef628da
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding a test for the case where this yields some other exception (e.g. due to a weird metaclass)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Seems like for normal classes, if any strange exception is raised when trying to lookup
__set_name__
, the interpreter just swallows it and moves on:We should do the same here (though I don't want to swallow
BaseException
s, since that would catchKeyboardInterrupt
,SystemExit
, etc. -- I think I'll just useexcept Exception
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 1909fd5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like a bug. I do not think it should be reproduced here. It is better to fix it for normal classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I opened #112453, and will revert the changes made here that reproduce the bug