gh-90633: Improve error and docs for typing.assert_never #91720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested review from
gvanrossum and
Fidget-Spinner
as code owners
Fidget-Spinner
approved these changes
Apr 20, 2022
AlexWaygood
reviewed
Apr 20, 2022
There was a problem hiding this comment.
Perhaps it might be nice to include a one-sentence explanation of how the type checker determines unreachability here (by narrowing the type such that the only satisfiable type is the empty bottom type, Never). That might clear up some of the user confusion that we had in the linked issue.
|
@AlexWaygood good point, I expanded the docs. |
AlexWaygood
reviewed
Apr 24, 2022
Thanks Alex! Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#90633