Make version check equal to or more than instead of more than

[msaroufim]

EDIT: This PR is causing a bunch of IMA issues on PyTorch 2.3 which is unexpected

This PR solves 2 issues

1. Our current version guard checks were incorrect TORCH_VERSION_AFTER_2_3(2.3) would return false for 2.3 and that's because we intended to say (see below for more detail) and adding .dev was obscuring the actual intent
2. The second issue is the name we were using was confusing so renamed TORCH_VERSION_AFTER_X_X to TORCH_VERSION_AT_LEAST_X_X,

import torch
torch.__version__ # prints 2.3.0
from torchao.utils import torch_version_at_least
torch_version_at_least("2.3.0.dev) # was returning false for 2.3.0 but True for 2.3.1

But after changes in this PR

torch_version_at_least("2.3.0.dev") # True
torch_version_at_least("2.3.0") # True

Also tested with 3.5

Python 3.10.14 (main, May  6 2024, 19:42:50) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from torchao.utils import torch_version_at_least
>>> from torchao.utils import torch_version_at_least
KeyboardInterrupt
>>> torch_version_at_least("2.5.0.dev")
True
>>> torch_version_at_least("2.5.0")
True
>>> import torch
>>> torch.__version__
'2.5.0.dev20240708+cu121'
>>> 
>>> from torchao.utils import TORCH_VERSION_AFTER_2_5
>>> TORCH_VERSION_AFTER_2_5

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/485

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit fbb61fc with merge base ab4ec43 ():

NEW FAILURES - The following jobs have failed:

• Run Regression Tests / test (CPU Nightly, linux.4xlarge, --pre torch --index-url https://download.pytorch.org/whl/nightl... / linux-job (gh)
  test/integration/test_integration.py::SmoothquantIntegrationTest::test_on_dummy_distilbert
• Run Regression Tests / test (CUDA 2.3, linux.g5.12xlarge.nvidia.gpu, torch==2.3.0, cuda, 12.1) / linux-job (gh)
  test/sparsity/test_wanda.py::TestWandaSparsifier::test_two_layer_mlp_unstructured

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[jerryzh168]

thanks!

[msaroufim]

Looks like there's some weird caching issue where Github is running older code and failing

EDIT: @kit1980 figured out I just needed to rebase

[gau-nernst]

Found some issues with the current TORCH_VERSION_AFTER_X_X. In CI

• torch 2.2.2: TORCH_VERSION_AFTER_2_2 return True
• torch 2.3: TORCH_VERSION_AFTER_2_3 return False

So I think changing it to TORCH_VERSION_AT_LEAST_X_X is the way to go.

The failing test in this PR is probably because people expect the old behavior? To make CI pass, probably some places you need to replace TORCH_VERSION_AFTER_2_2 with TORCH_VERSION_AT_LEAST_2_3 for example.