Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NF4Tensor to use dispatch utils #543

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jerryzh168
Copy link
Contributor

Summary:
As a follow up of #542, we can simplify the code of nf4tensor by using the dispatch utils as well.

Test Plan:
python test/dtypes/test_nf4.py

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Jul 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/543

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 452901a with merge base afde175 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2024
Summary:
As a follow up of pytorch#542, we can simplify the code
of nf4tensor by using the dispatch utils as well.

Test Plan:
python test/dtypes/test_nf4.py

Reviewers:

Subscribers:

Tasks:

Tags:
@jerryzh168
Copy link
Contributor Author

jerryzh168 commented Jul 26, 2024

Note: it seems that some ops are implemented this way to work with QLoRA. from @weifengpy:

I remember they hack around state dict loading and has to call args[1]["dtype"] instead of kwargs["dtype"] so changing the behavior might break single-device QLoRA recipe

So I'll leave this refactor to nf4 people. cc @msaroufim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants