Merge pull request #4 from qnrl/feature/refactor

Move child resources to ref parent

.devcontainer/devcontainer.json

@@ -44,6 +44,7 @@
         "msazurermtools.azurerm-vscode-tools",
         "ms-azuretools.vscode-bicep",
         "ms-azure-devops.azure-pipelines",
+        "github.vscode-github-actions",
         "shuworks.vscode-table-formatter",
         "streetsidesoftware.code-spell-checker",
         "wmaurer.change-case",

.github/workflows/repository.yml → .github/workflows/analyse-psrule.yml

@@ -8,7 +8,7 @@
 # For action details see:
 # https://aka.ms/ps-rule-action
 
-name: Analyze repository
+name: Analyze with PsRule
 
 # Run for main or PRs against main
 on:
@@ -18,6 +18,7 @@ on:
   pull_request:
     branches:
       - main
+  workflow_dispatch:
 
 jobs:
   analyze:
@@ -27,7 +28,8 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v3
 
+      # Run analysis by using the PSRule GitHub action.
       - name: Run PSRule analysis
-        uses: Microsoft/[email protected]
+        uses: microsoft/[email protected]
         with:
           modules: PSRule.Rules.Azure

.vscode/extensions.json

@@ -8,6 +8,7 @@
     "msazurermtools.azurerm-vscode-tools",
     "ms-azuretools.vscode-bicep",
     "ms-azure-devops.azure-pipelines",
+    "github.vscode-github-actions",
     "shuworks.vscode-table-formatter",
     "streetsidesoftware.code-spell-checker",
     "wmaurer.change-case",

modules/storage/v1/storage.bicep

@@ -36,17 +36,30 @@ resource sa 'Microsoft.Storage/storageAccounts@2022-09-01' = {
         environment: 'Production'
         costCode: '123456'
     }
-    resource blobs 'blobServices@2022-09-01' = {
-        name: 'default'
-        properties: {
-            deleteRetentionPolicy: {
-                enabled: true
-                days: 7
-            }
-            containerDeleteRetentionPolicy: {
-                enabled: true
-                days: 7
-            }
+}
+
+resource blobs 'Microsoft.Storage/storageAccounts/blobServices@2022-09-01' = {
+    name: 'default'
+    parent: sa
+    properties: {
+        deleteRetentionPolicy: {
+            enabled: true
+            days: 7
+        }
+        containerDeleteRetentionPolicy: {
+            enabled: true
+            days: 7
+        }
+    }
+}
+
+resource files 'Microsoft.Storage/storageAccounts/fileServices@2022-09-01' = {
+    name: 'default'
+    parent: sa
+    properties: {
+        shareDeleteRetentionPolicy: {
+            enabled: true
+            days: 7
         }
     }
 }

ps-rule.yaml

@@ -45,14 +45,14 @@ input:
 
   # Exclude bicepconfig.json
   - 'bicepconfig.json'
-  
+
   # ignore all bicep files except the ones that have been created to test modules
   - 'modules/**/*.bicep'
   - '!modules/**/*.tests.bicep'
 
 rule:
   exclude:
-    - "Azure.Storage.UseReplication"
+    - Azure.Storage.UseReplication
 
 include:
   module: