-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gradlew.bat/mvnw.bat should NOT be executable #20513
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
Thanks @s-soroosh, can you confirm it won't change anything on Windows? |
...vtools-common/src/main/java/io/quarkus/devtools/project/compress/QuarkusProjectCompress.java
Outdated
Show resolved
Hide resolved
Can you squash both commits and let us know that this works on Windows? |
BTW should I fix gradle-wrapper/codestart.yml and maven-wrapper/codestart.yml as well? cc @ia3andy |
There are two layers depending on if we zip the project or not: |
I've played a bit with |
7682169
to
f2c18cb
Compare
@seregamorph awesome! thanks for the investigation :) You are good to do both changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
is the CI failing due to that PR or something else? |
@ia3andy , I cannot give guarantee, but I've checked last main branch commits, most of them have CI/CD objections (red cross): |
@seregamorph I've restarted the CI to be sure ;) |
@ia3andy feel free to merge is this is good to go |
If the gradle project is generated, the root directory listing has these gradle-wrapper related files:
The problem is that the second one, the bat file should not be executable, because it is auto-suggested in the shell to be executed, it raises inconvenience and requires manual fixing (via chmod). You can ensure and just list e.g. root directory of quarkus:
The first file for *nix has the executable flag, the second file for Windows - does not.
This PR addresses the issue.
The same for maven wrapper bat executable.