Rotate vector around abitrary axis #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartercastle
force-pushed
the
rotate-around-vector
branch
3 times, most recently
from
c2763d6
to
463563b
Compare
The old implementation worked with predefined X, Y, Z axis which are quit limiting. A better solution is to simply take a vector as the axis, this allows a vector to be rotate around an abitrary axis if needed.
quartercastle
force-pushed
the
rotate-around-vector
branch
from
d85c34a
to
2b5fa3b
Compare
quartercastle
force-pushed
the
rotate-around-vector
branch
from
2b5fa3b
to
48578e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation worked with predefined X, Y and Z axis which where quit
limiting. A better solution is to simply take a vector as the axis, this
allows a vector to be rotate around an abitrary axis if needed.
Resolve #9.