FIX: Fixes dot() returning NaN. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartercastle
requested changes
Sep 23, 2022
There was a problem hiding this comment.
Thank you for fixing this @SolarLune, can i get you to add a unit test to verify this case, just to ensure it isn't reintroduced in the future?
SolarLune
force-pushed
the
master
branch
2 times, most recently
from
dcb498d
to
e2b3ea7
Compare
This seems to be due to floating point inaccuracies.
|
Whoops, sorry about that - OK, I force updated my master branch so the current PR now includes a simple dot NaN test. |
quartercastle
approved these changes
Sep 26, 2022
|
Excellent - and sorry for the confusing title / description, haha. This issue affects both dot() and angle(). |
|
Yeah, i figured that out after seeing the code. Once again thanks for the contribution! :) |
quartercastle
added a commit
that referenced
this pull request
Jul 22, 2023
This reverts commit 007106a.
quartercastle
added a commit
that referenced
this pull request
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a PR to fix angle() sometimes returning NaN with specific long-running vectors; this is probably due to floating-point inaccuracies.
As an example, without this PR, this:
returns NaN instead of 0 (and similarly NaN instead of
piif the vector were to be tested against its opposite).