#5 - Adding Angle() function. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixing Vector.Cross(), because the function's formula was incorrect (double-checked using https://www.vcalc.com/wiki/vCalc/V3+-+V+x+U and https://www.omnicalculator.com/math/cross-product).
quartercastle
requested changes
May 4, 2020
There was a problem hiding this comment.
Thank you for the contribution @SolarLune, its much appreciated!
I just have a couple of comments and would like if you could create a benchmark test for the method as well.
Not really useful until Vector.Rotate() takes arbitrary Vectors. Fixing tests, adding benchmark.
|
OK, I added your requests into the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixing Vector.Cross(), because the function's formula was incorrect (double-checked using https://www.vcalc.com/wiki/vCalc/V3+-+V+x+U and https://www.omnicalculator.com/math/cross-product).
Resolves #5.