Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heat Index Feature #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Heat Index Feature #17

wants to merge 3 commits into from

Conversation

ClementGre
Copy link

Hi, I use your app every day to compare the outside/inside temperature, but the temperature is not enough to compare wether or not to open the windows. That's why I developed a feature that calculates and display the heat index for sensors that support both temperature and humidity measurement.

What I've done

  • Adding a function to calculate heat index in unitemp.c.
  • Sensors.c calls this function to calculate heat index when updating sensor data.
  • Adding a new function in General_view.c to draw the heat index for sensors of type UT_DATA_TYPE_TEMP_HUM, with a new icon derivated from the temp_C and temp_F icon.
  • Adding an option in the settings to disable the heat index calculation and display of the heat index.

What you could add to my code to integrate it better to the app

  • Maybe update the new icon that might not be explicit enough.
  • Supporting the display of head index for sensors of type UT_DATA_TYPE_TEMP_HUM_CO2 (this will require to change _draw_co2 to support custom coordinates). As long as there is no sensor that supports temp, hum, co2 and press, there is anyway enough room to show the heat index.
  • The heat index could be shown smaller because it is not a directly measured by the sensor, it is a calculation, but it would require to change even more the layout of the measures tiles.
  • Adding a new scene that shows all the heat indices of all sensors would allow an easier comparaison.

divinebird and others added 3 commits June 4, 2023 12:51
Append carbon dioxide sensor (SCD30)
- Adding a function to calculate heat index in unitemp.c
- Sensors.c calls this function to calculate heat index when updating sensor data.
- Adding a new function in General_view.c to draw the heat index for sensors of type UT_DATA_TYPE_TEMP_HUM, with a new icon derivated from the temp_C and temp_F icon.
- Adding an option in the settings to disable the heat index calculation and display.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants