Operator metrics #602
Merged
Operator metrics #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The operator metrics default port is 9782. Enable operator metrics by default (which was already the case before this commit.) As of now, the operator metrics do not contain sensitive information. Therefore, there is no need to use basic auth and a proxy to scrape the metrics. Hence, remove the auth proxy patch file. Include the metrics port in the mangager deployment YAML so that we can create PodMonitors to point to the metrics port. Add examples how to scrape the operator metrics.
MirahImage
approved these changes
Feb 15, 2021
mkuratczyk
approved these changes
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the following patch files:
manager_auth_proxy_patch.yaml: As of now, the operator metrics do not contain sensitive information. Therefore, there is no need to use basic auth and a proxy to scrape the metrics.manager_disable_metrics_patch.yaml: Up until now metrics were enabled in make targetsgenerate-installation-manifest(the production YAML),deploy-kind,deploy-dev. This file got only applied when runningdeploy-manager. However, we want to expose metrics by default. There is no need to disable metrics in make targetdeploy-manager.manager_prometheus_metrics_patch.yaml: Since we enable operator metrics by default, we put the port spec directly intoconfig/manager/manager.yaml. I left out the annotationprometheus.io/scrape: 'true'on purpose since one should use monitors when using the Prometheus operator instead of relying on the annotation (see Update manifests to latest version of Prometheus Operator prometheus-operator/kube-prometheus#16 (comment)).Add (HTTP only) examples how to scrape the operator metrics.
This PR does not change any behaviour. Before and after this PR, port
9782is exposed.However, this PR adds a named
metricsport to the manager deployment YAML such that a PodMonitor can scrape the metrics without using the deprecated targetPort.