Adding a way to bypass the notebook token. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss check and making it part of the image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also extending the readiness check and making it part of the base image.
By default everything is the same as before. Only if the
JUPYTER_NOTEBOOK_DISABLE_TOKENis set totrue, the token will be set to an empty string, this means it will not be generated/required by Jupyter. If theJUPYTER_NOTEBOOK_PASSWORDis set to an non empty string, this password will be required during the first access to the notebook (no matter, if the token is generated/set or disabled). In other words, setting the both abovementioned env variables at the same time doesn't make sense.If there is no authN, the
ready.shscript will check also the endpoint with the notebooks (/tree). Also adding theready.shto the image so that it can be used in the openshift for ready/live checks.