Addressing Rails Edge breaking change with insert_all #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also updated |
ron-shinall
force-pushed
the
insert-all-breaking-change
branch
from
b2297e7
to
a79b6ac
Compare
Also updated rails_main.gemfile.lock to latest rails main
ron-shinall
force-pushed
the
insert-all-breaking-change
branch
from
a0ab5de
to
157639d
Compare
|
@djmb thoughts on this? |
|
Thanks for the PR @ron-shinall. This is needed because of the query cache workarounds (see #123) which involved using AR internals (and is exactly why we shouldn't have those workarounds!). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a breaking change with Rails Edge
insert_all. Prior to the change,insert_allused the connection of the model argument (model.connection). Now the connection has to be passed in as a separate argument.I have tested this with Appraisal using
rails-7,rails-7-1, andrails-mainon Ruby 3.3.0.Rails commit: rails/rails@1c0982d
Fixes #164