-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct Navbar Height and Spacing Issues #549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can you remove the unnecessary padding line?
css/style.css
Outdated
@@ -134,6 +139,15 @@ footer p:last-child { | |||
margin-bottom: 0; | |||
} | |||
|
|||
.nav { | |||
margin-bottom: 0; | |||
padding: 20px auto; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, Firefox gives an "Invalid property value" error, because padding
can't have an auto
value.
padding: 20px auto; |
Removing it also works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure.
background-image: url("/images/icon-text-editor.png"); | ||
} | ||
|
||
i.icon-prompt { | ||
background-image: url('/images/icon-prompt.png'); | ||
background-image: url("/images/icon-prompt.png"); | ||
} | ||
|
||
i.icon-browser { | ||
background-image: url('/images/icon-browser.png'); | ||
background-image: url("/images/icon-browser.png"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback for next time: Keep the changes limited to necessary changes so it's easier to review and we don't have to check code style changes to see if they impact the design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I greatly appreciate your feedback. I'll make sure to keep my changes more focused on my future contributions.
…ssary Padding Line
@tombruijn Thank you for your valuable suggestions. I have made the recommended changes in the latest commit. When you have a moment, could you please re-review the updated code? Your feedback is greatly appreciated. |
Description
This pull request addresses the concerns outlined in Issue #548, focusing on enhancing the user interface (UI) of the website's navbar (header). The primary issues tackled in this PR are the excessive navbar height and improper spacing, both of which contribute to an undesirable user experience.
Fixes #548
Changes
Previews
Before:
![before](https://private-user-images.githubusercontent.com/64830641/275946167-e23266d9-8a20-45f0-a50f-df63d9f057c8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3MzM1MjIsIm5iZiI6MTcyNTczMzIyMiwicGF0aCI6Ii82NDgzMDY0MS8yNzU5NDYxNjctZTIzMjY2ZDktOGEyMC00NWYwLWE1MGYtZGY2M2Q5ZjA1N2M4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA3VDE4MjAyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMzMmRlNDQ4ZDAxZDVkNjE1YTEyZjk5MzcyNGFhZWVjOTRiOGViNmFiZDBjMzA1ZGYwNDc1MzhmNDdhMGY1YjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.BJHOQsnsG0kVOGPsdicxq-yfkyGRF2RbJDgBOzzpIe4)
After:
![after](https://private-user-images.githubusercontent.com/64830641/275939819-1ec08431-4079-4023-badb-3f034940febe.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3MzM1MjIsIm5iZiI6MTcyNTczMzIyMiwicGF0aCI6Ii82NDgzMDY0MS8yNzU5Mzk4MTktMWVjMDg0MzEtNDA3OS00MDIzLWJhZGItM2YwMzQ5NDBmZWJlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA3VDE4MjAyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTViYjEwNDNjY2M1OWQwYTdmYTU5OTEzMTkwNTc0ZTU0M2E1ZDdiMzVkZGI3YzQ3MzFkMzhhY2JlNzdlODExYzUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ttIRwwtXyQfxKNlr3CUXlvUPhchKWzbCcy1vOSkbKDQ)
Checklist: