fix: Correct Navbar Height and Spacing Issues #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombruijn
reviewed
Oct 18, 2023
css/style.css
Outdated
| @@ -134,6 +139,15 @@ footer p:last-child { | |||
| margin-bottom: 0; | |||
| } | |||
|
|
|||
| .nav { | |||
| margin-bottom: 0; | |||
| padding: 20px auto; | |||
There was a problem hiding this comment.
For me, Firefox gives an "Invalid property value" error, because padding can't have an auto value.
Suggested change
| padding: 20px auto; |
Removing it also works for me.
Comment on lines
+259
to
+267
| background-image: url("/images/icon-text-editor.png"); | ||
| } | ||
|
|
||
| i.icon-prompt { | ||
| background-image: url('/images/icon-prompt.png'); | ||
| background-image: url("/images/icon-prompt.png"); | ||
| } | ||
|
|
||
| i.icon-browser { | ||
| background-image: url('/images/icon-browser.png'); | ||
| background-image: url("/images/icon-browser.png"); |
There was a problem hiding this comment.
Feedback for next time: Keep the changes limited to necessary changes so it's easier to review and we don't have to check code style changes to see if they impact the design.
There was a problem hiding this comment.
I greatly appreciate your feedback. I'll make sure to keep my changes more focused on my future contributions.
…ssary Padding Line
|
@tombruijn Thank you for your valuable suggestions. I have made the recommended changes in the latest commit. When you have a moment, could you please re-review the updated code? Your feedback is greatly appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the concerns outlined in Issue #548, focusing on enhancing the user interface (UI) of the website's navbar (header). The primary issues tackled in this PR are the excessive navbar height and improper spacing, both of which contribute to an undesirable user experience.
Fixes #548
Changes
Previews
Before:
After:
Checklist: