Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish image snapshots to ghcr.io #84

Merged
merged 2 commits into from
Dec 18, 2022
Merged

publish image snapshots to ghcr.io #84

merged 2 commits into from
Dec 18, 2022

Conversation

flavorjones
Copy link
Collaborator

See #71 for context.

This is a draft to try to publish snapshots of the docker images to ghcr.io for integration testing on other projects.

@flavorjones flavorjones force-pushed the 71-flavorjones-publish-images-to-ghcr branch 4 times, most recently from 8f7dbc7 to ebf3a06 Compare December 17, 2022 20:22
@flavorjones
Copy link
Collaborator Author

woot!

@flavorjones flavorjones force-pushed the 71-flavorjones-publish-images-to-ghcr branch from ebf3a06 to 0d31e59 Compare December 17, 2022 20:30
@flavorjones flavorjones marked this pull request as ready for review December 17, 2022 20:30
@flavorjones
Copy link
Collaborator Author

Note: I don't think the image naming here is completely right, it's different from lars's dockerhub names and also doesn't take into consideration the work @ianks is doing at #79 to build arm64 host images.

@ianks
Copy link

ianks commented Dec 17, 2022

Note: I don't think the image naming here is completely right, it's different from lars's dockerhub names and also doesn't take into consideration the work @ianks is doing at #79 to build arm64 host images.

As far as #79 is concerned, it shouldn't affect the naming at all (since the image is automatically selected by Docker via the --platform flag).

@flavorjones
Copy link
Collaborator Author

the image is automatically selected by Docker via the --platform flag

Ah! OK, I get it.

@flavorjones flavorjones force-pushed the 71-flavorjones-publish-images-to-ghcr branch 12 times, most recently from 17763a7 to 7566139 Compare December 18, 2022 16:52
@flavorjones flavorjones force-pushed the 71-flavorjones-publish-images-to-ghcr branch from 7566139 to b38eac1 Compare December 18, 2022 16:54
@flavorjones flavorjones merged commit aad7df5 into master Dec 18, 2022
@flavorjones flavorjones deleted the 71-flavorjones-publish-images-to-ghcr branch December 18, 2022 22:12
@flavorjones flavorjones mentioned this pull request Dec 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flavorjones @ianks