-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change location of docker images to ghcr.io #95
Conversation
2680fa1
to
998b23b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you about the better name DOCKER_REGISTRY
.
@larskanis I think I'd like to use a single container repository for all the images. Would you be open to changing the container name and tag format from:
to:
So, for example:
The main advantage is that we could use a single image repository, This would also still work with the idea of shipping different host architectures, see #79. |
Yes, there are so many images now, that we should move the platform into the tag part. I already thought about it and when we touch the logic now, it's a good chance to change it now. |
OK, I'm traveling a bit today but will get to this in the next day or so. |
note we also drop the env var DOCKERHUB_USER in favor of CONTAINER_REGISTRY
with new tag format
ad82c8f
to
f336a3c
Compare
6a9bb38
to
2f4af4a
Compare
Running a Nokogiri pipeline using this repo and the snapshot images here: sparklemotion/nokogiri#2756 Edit: those CI jobs went green! |
5f0c333
to
869e4c5
Compare
in addition to the :rubyvm option
086cd2d
to
187e671
Compare
See context from #71 and #87
This PR moves from dockerhub
larskanis
account to the github registry for the rake-compiler org. It keeps support for theDOCKERHUB_USER
environment variable but also supports an env var with a more appropriate name,DOCKER_REGISTRY
.@larskanis Would love your feedback on this!