Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change location of docker images to ghcr.io #95

Merged
merged 7 commits into from
Jan 11, 2023

Conversation

flavorjones
Copy link
Collaborator

See context from #71 and #87

This PR moves from dockerhub larskanis account to the github registry for the rake-compiler org. It keeps support for the DOCKERHUB_USER environment variable but also supports an env var with a more appropriate name, DOCKER_REGISTRY.

@larskanis Would love your feedback on this!

Copy link
Member

@larskanis larskanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you about the better name DOCKER_REGISTRY.

test/test_environment_variables.rb Outdated Show resolved Hide resolved
lib/rake_compiler_dock/starter.rb Outdated Show resolved Hide resolved
@flavorjones
Copy link
Collaborator Author

@larskanis I think I'd like to use a single container repository for all the images. Would you be open to changing the container name and tag format from:

#{REGISTRY}/rake-compiler-dock-#{RUBYVM}#{PLATFORM_POSTFIX}:#{VERSION}

to:

#{REGISTRY}/rake-compiler-dock-image:#{VERSION}-#{RUBYVM}#{PLATFORM_POSTFIX}

So, for example:

  • ghcr.io/ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-mri-x86_64-linux
  • ghcr.io/ghcr.io/rake-compiler/rake-compiler-dock-image:1.3.0-jruby
  • ghcr.io/ghcr.io/rake-compiler/rake-compiler-dock-image:snapshot-mri-arm64-darwin

The main advantage is that we could use a single image repository, ghcr.io/rake-compiler/rake-compiler-dock-images (rather than a separate repository per platform), which would simplify administration. This is also similar to what many other projects do: use the label as an indicator of both version and "flavor" (e.g., ruby/ruby:3.2-alpine).

This would also still work with the idea of shipping different host architectures, see #79.

@larskanis
Copy link
Member

Yes, there are so many images now, that we should move the platform into the tag part. I already thought about it and when we touch the logic now, it's a good chance to change it now.

@flavorjones
Copy link
Collaborator Author

OK, I'm traveling a bit today but will get to this in the next day or so.

@flavorjones flavorjones force-pushed the flavorjones-move-to-ghcr.io branch 3 times, most recently from ad82c8f to f336a3c Compare January 9, 2023 17:47
@flavorjones
Copy link
Collaborator Author

flavorjones commented Jan 10, 2023

Running a Nokogiri pipeline using this repo and the snapshot images here: sparklemotion/nokogiri#2756

Edit: those CI jobs went green!

@flavorjones flavorjones force-pushed the flavorjones-move-to-ghcr.io branch 3 times, most recently from 5f0c333 to 869e4c5 Compare January 11, 2023 18:02
in addition to the :rubyvm option
@flavorjones flavorjones merged commit 2b6620a into master Jan 11, 2023
@flavorjones flavorjones deleted the flavorjones-move-to-ghcr.io branch January 11, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants