Fix: Typo of explicit restriction in RestrictionReason
#332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioortizmanero
approved these changes
Jun 21, 2022
|
Thanks @marioortizmanero, just out of curiosity: is a release planned anytime soon? |
|
Another option is to merge all of the PRs except for #305, which is the truly breaking & bigger change, and release a 0.11.6 release in the meanwhile. But it depends on how fast we can merge the other ones and etc. |
|
The second approach sounds nice, but please don't feel rushed by this comment or my previous question :) Thanks! |
|
Sooo @marioortizmanero, any plans for a bugfix release? 😅 |
|
I released a new version: #373 |
|
Thanks @ramsayleung ❤️ |
hrkfdn
added a commit
to hrkfdn/ncspot
that referenced
this pull request
Dec 14, 2022
Passing IDs to rspotify still feels a little wonky with their `Id` changes making use of `Cow`. Maybe it can be simplified on our end, but it's a start. Fixes #844 See also: ramsayleung/rspotify#332
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 29, 2022
Maintenance - Fix: Handle explicit field from Spotify API (#844, ramsayleung/rspotify#332) - Fix: Print "Connecting to Spotify" before setting up Cursive backend by @pghvlaans (#969) - Link to Flatpak image by @thorpelawrence (#997) - Make entry point synchronous and switch to global runtime instead by @ThomasFrans (#996) - Document queue module by @ThomasFrans (#1009) Features - Add "save/unsave album" to context menu (#964) - Automatically save backtraces to cache folder by @ThomasFrans (#988) - Create IPC socket on UNIX platforms for remote control and external track display (#1018)
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 18, 2023
Maintenance - Fix: Handle explicit field from Spotify API (#844, ramsayleung/rspotify#332) - Fix: Print "Connecting to Spotify" before setting up Cursive backend by @pghvlaans (#969) - Link to Flatpak image by @thorpelawrence (#997) - Make entry point synchronous and switch to global runtime instead by @ThomasFrans (#996) - Document queue module by @ThomasFrans (#1009) Features - Add "save/unsave album" to context menu (#964) - Automatically save backtraces to cache folder by @ThomasFrans (#988) - Create IPC socket on UNIX platforms for remote control and external track display (#1018)
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 23, 2023
Maintenance - Fix: Handle explicit field from Spotify API (#844, ramsayleung/rspotify#332) - Fix: Print "Connecting to Spotify" before setting up Cursive backend by @pghvlaans (#969) - Link to Flatpak image by @thorpelawrence (#997) - Make entry point synchronous and switch to global runtime instead by @ThomasFrans (#996) - Document queue module by @ThomasFrans (#1009) Features - Add "save/unsave album" to context menu (#964) - Automatically save backtraces to cache folder by @ThomasFrans (#988) - Create IPC socket on UNIX platforms for remote control and external track display (#1018)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like there is a typo in the enum values. Not sure if this would considered a breaking change since the enum options are changing.
Motivation and Context
hrkfdn/ncspot#844
Type of change
Please delete options that are not relevant.
How has this been tested?
See link above. I didn't explicitly test it, but it's surely a typo :)