Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][v2.8] GHA CI #471

Open
wants to merge 20 commits into
base: release/v4.0
Choose a base branch
from
Open

Conversation

alexandreLamarre
Copy link
Contributor

Backport of :
#455
#457
#469

alexandreLamarre and others added 15 commits May 13, 2024 11:23
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
Signed-off-by: Alexandre Lamarre <[email protected]>
@alexandreLamarre alexandreLamarre marked this pull request as ready for review May 13, 2024 15:40
@alexandreLamarre alexandreLamarre marked this pull request as draft May 13, 2024 18:32
@alexandreLamarre alexandreLamarre marked this pull request as ready for review May 13, 2024 19:10
.goreleaser.yaml Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions -- I tested the changes I use locally (like scripts/deploy and they're all good

Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need same changes happening on release/v5.0 re the published binaries and charts tgz

@alexandreLamarre alexandreLamarre marked this pull request as draft May 14, 2024 17:49
Compile release binaries only for linux amd & arm

Change release binary name format to match previous one

Signed-off-by: Alexandre Lamarre <[email protected]>
@alexandreLamarre alexandreLamarre marked this pull request as ready for review June 13, 2024 10:56
@ericpromislow ericpromislow dismissed their stale review July 2, 2024 16:20

Will wait until 2.9 is doe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants