Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock caused by apiserver outage during init #79

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

brandond
Copy link
Contributor

@brandond brandond commented Aug 15, 2023

We had similar code to prevent blocking when calling Update(), but not in the init function.

func (s *storage) Update(secret *v1.Secret) error {
// Asynchronously update the Kubernetes secret, as doing so inline may block the listener from
// accepting new connections if the apiserver becomes unavailable after the Secrets controller
// has been initialized. We're not passing around any contexts here, nor does the controller
// accept any, so there's no good way to soft-fail with a reasonable timeout.

Ref: rancher/rancher#42278

We had similar code to prevent blocking when calling Update(), but not in the init function.

Ref: rancher/rancher#42278
Signed-off-by: Brad Davidson <[email protected]>
@brandond brandond merged commit 1c60bf4 into rancher:master Aug 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants