Cortex config refactor part 2 #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kralicky
force-pushed
the
cortex-config-bugfixes-wip
branch
from
2c4796a
to
9e9d87e
Compare
This is to ensure randomly generated messages can be converted to and from json without loss of precision, since json encodes all numbers as float64s.
kralicky
force-pushed
the
cortex-config-bugfixes-wip
branch
from
49539e1
to
0d1e434
Compare
kralicky
force-pushed
the
cortex-config-bugfixes-wip
branch
2 times, most recently
from
ab603e3
to
1fa60df
Compare
kralicky
force-pushed
the
cortex-config-bugfixes-wip
branch
from
1fa60df
to
95c1df4
Compare
alexandreLamarre
requested changes
Sep 11, 2023
…ions When resetting the active config (with or without supplying a mask), and the config message type has a field named 'enabled', the server will create a new revision and preserve history, instead of deleting the object from the active store. When there is no 'enabled' field in the message type, it will delete the object as usual. Add revision field to generic history request Add unit tests for the base config server
…/discard algorithms
kralicky
force-pushed
the
cortex-config-bugfixes-wip
branch
from
af87a3e
to
6cf16b1
Compare
alexandreLamarre
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.